Added filename placeholder in winbuild URL - Githubissues

python-pillow / Pillow

Python Imaging Library (Fork)

https://python-pillow.org

Other

12.32k stars 2.23k forks source link

Added filename placeholder in winbuild URL #8498

Closed radarhere closed 3 weeks ago

radarhere commented 4 weeks ago

There are several places in winbuild/build_prepare.py where the "filename" is replicated in the "url" https://github.com/python-pillow/Pillow/blob/822ec3d05dfbaf2e3209c2b26e3392040e274975/winbuild/build_prepare.py#L163-L165

I wonder if

"zlib": {
    "url": "https://zlib.net/FILENAME",
    "filename": f"zlib{V['ZLIB_DOTLESS']}.zip",

is neater, reducing duplication?

Feel free to reject if others think it isn't simpler.