search

python-pillow / Pillow

Python Imaging Library (Fork)
https://python-pillow.org
Other
12.32k stars 2.23k forks source link

Add trove-classifiers>=2024.10.12 to 'tests' extra and use for Windows CI #8514

Closed hugovk closed 2 weeks ago

hugovk commented 3 weeks ago

Re: https://github.com/python-pillow/Pillow/pull/8513#discussion_r1820775250

trove-classifiers>=2024.10.12 is required for the pyroma tests.

Removes duplication of test dependencies.

hugovk commented 3 weeks ago

Strange, pypy3 couldn't find trove-classifiers>=2024.10.12, and 2024.7.2 is the latest it can find:

INFO: pip is looking at multiple versions of pillow[tests] to determine which version is compatible with other requirements. This could take a while.
ERROR: Could not find a version that satisfies the requirement trove-classifiers>=2024.10.12; extra == "tests" (from pillow[tests]) (from versions: 2020.4.1, 2020.4.9, 2020.5.11, 2020.5.21, 2020.6.20, 2020.7.30, 2020.8.3, 2020.8.6, 2020.8.7, 2020.8.11, 2020.8.14, 2020.8.17, 2020.9.3, 2020.9.8, 2020.9.25, 2020.10.6, 2020.10.7, 2020.10.21, 2021.1.14, 2021.2.28, 2021.4.5, 2021.7.10, 2021.8.4, 2021.8.31, 2021.9.17, 2021.9.22, 2021.9.23, 2021.9.27, 2021.10.9, 2021.10.20, 2021.11.16, 2021.11.17, 2022.1.3, 2022.1.6, 2022.2.16, 2022.3.10, 2022.3.16, 2022.3.17, 2022.3.21, 2022.3.30, 2022.4.11, 2022.4.30, 2022.5.5, 2022.5.11, 2022.5.12, 2022.5.19, 2022.6.23, 2022.6.26, 2022.7.22, 2022.8.7, 2022.8.24, 2022.8.31, 2022.9.26, 2022.10.19, 2022.12.1, 2022.12.22, 2023.1.12, 2023.1.20, 2023.2.8, 2023.2.20, 2023.3.9, 2023.4.18, 2023.4.20, 2023.4.22, 2023.4.25, 2023.4.29, 2023.5.2, 2023.5.22, 2023.5.24, 2023.7.6, 2023.8.7, 2023.9.19, 2023.10.17, 2023.10.18, 2023.11.7, 2023.11.9, 2023.11.13, 2023.11.14, 2023.11.22, 2023.11.29, 2024.1.8, 2024.1.31, 2024.2.22, 2024.2.23, 2024.3.3, 2024.3.25, 2024.4.10, 2024.5.17, 2024.5.22, 2024.7.1, 2024.7.2)

Notice:  A new release of pip is available: 24.2 -> 24.3.1
Notice:  To update, run: python.exe -m pip install --upgrade pip
ERROR: No matching distribution found for trove-classifiers>=2024.10.12; extra == "tests"
Traceback (most recent call last):
  File "D:\a\Pillow\Pillow\selftest.py", line 7, in <module>
    from PIL import Image, features
ModuleNotFoundError: No module named 'PIL'

But https://pypi.org/project/trove-classifiers/2024.10.12/ and newer are on PyPI.

It installed it and passed on my fork:

https://github.com/hugovk/Pillow/actions/runs/11588271332/job/32277504083#step:25:132

hugovk commented 2 weeks ago

I'm not convinced this isn't just passing now because of the cleared caches

Yeah, I think so, here's a similar report: https://github.com/actions/setup-python/issues/972

The pyroma test is skipped when trove-classifiers isn't installed.

But if we want to run it, trove-classifiers>=2024.10.12 is a required dependency. We shouldn't really just hope we end up with a newer one installed into the system.