Closed piby180 closed 1 month ago
When timeout is provided as a query parameter in connection string, like the following
'pinot://localhost:8000/query/sql?controller=' 'http://localhost:9000/&&verify_ssl=True&&timeout=100'
we get TypeError : 'str' can't be converted to int
We need to convert timeout from string to int and then use it. This is fixed in this PR.
can you please fix the test ?
@xiangfu0 Test has been fixed. The issue was that timeout in test here was being converted to 0 since int(0.001) = 0.
I have now used float() for timeout instead of int() which is also consistent with httpx as timeout datatype there is union of float and Nonetype.
When timeout is provided as a query parameter in connection string, like the following
we get TypeError : 'str' can't be converted to int
We need to convert timeout from string to int and then use it. This is fixed in this PR.