Improve schemas and tables list

python-pinot-dbapi / pinot-dbapi

Python DB-API and SQLAlchemy dialect for Pinot

MIT License

20 stars 33 forks source link

Closed dd-willgan closed 2 years ago

dd-willgan commented 3 years ago

PinotDialect currently gets schemas and tables from the controller, but there are a couple issues with this:

In Pinot, schema refers to the table column definition, but in the context of SQLAlchemy schema generally refers to a directory / namespace of tables (e.g. in Postgres). This is confusing because in tools such as Superset you can select a schema then a table but with Pinot, they are more or less the same thing.

xiangfu0 commented 2 years ago

You are right. Pinot doesn't have the concept of schema. So here we just make the schema to accept any value.