search

python-pinot-dbapi / pinot-dbapi

Python DB-API and SQLAlchemy dialect for Pinot
MIT License
19 stars 33 forks source link

Increasing code coverage to 50% #61

Closed diogobaeder closed 1 year ago

diogobaeder commented 1 year ago

With these changes, we got to 50% code coverage for the project. I did a few slight improvements in the production code as I felt a bit more comfortable now with increased coverage.

I'll keep working on the rest of the coverage later; Just haven't reached 100% yet because it's a lot of work involved. It's my next task, though, and once I can cover at least 100% of the db module, I'd like to start refactoring the code a bit, to have a better distribution of responsibilities.

diogobaeder commented 1 year ago

Hi guys, any news on this? Did I miss anything?

diogobaeder commented 1 year ago

Thanks @xiangfu0 ! Now what's the plan to merge this?

xiangfu0 commented 1 year ago

Merged! Thanks a lot for your contributions!