search

python-pinot-dbapi / pinot-dbapi

Python DB-API and SQLAlchemy dialect for Pinot
MIT License
20 stars 33 forks source link

Increasing coverage #70

Closed diogobaeder closed 1 year ago

diogobaeder commented 1 year ago

Hi guys,

I've been working for a long time on increasing the code coverage for the library, and I wanted to have 100% coverage so that I could more confidently start refactoring it; But, given that I just started a new job and have been super busy, I chose to push what I currently have instead. It's 94% covered with these changes, and I still want to do a lot of improvements to the library (like some refactoring, implementing orjson/ujson support etc), but will have to delay my more important contributions a bit more.

Anyway, I hope this here is helpful. Sorry that the changes are not as meaningful as I wish they were.

diogobaeder commented 1 year ago

Hi guys! Any interest in merging these changes?

xiangfu0 commented 1 year ago

Many thanks @diogobaeder ! This is great! Really appreciate your epic work!