search

python-pinot-dbapi / pinot-dbapi

Python DB-API and SQLAlchemy dialect for Pinot
MIT License
19 stars 33 forks source link

Added support for providing a timeout option while setting up a connection #85

Closed aishikbh closed 9 months ago

aishikbh commented 9 months ago

Added support for adding a timeout option (in seconds) while setting up a connection. If no timeout is provided, the default behaviour is to have no timeouts.

walterddr commented 9 months ago

can we add some tests? there's no need to validate the query result but better to validate that the timeout actually is in effect

aishikbh commented 9 months ago

can we add some tests? there's no need to validate the query result but better to validate that the timeout actually is in effect

  • setting to 1ms and see if it actually times out
  • setting it explicitly to None and see if it follows default
  • other scenarios

I have added the tests.