search

python-pinot-dbapi / pinot-dbapi

Python DB-API and SQLAlchemy dialect for Pinot
MIT License
19 stars 33 forks source link

Password logged when initializing dialect #92

Closed pudom16 closed 5 months ago

pudom16 commented 5 months ago

Related to this snippet

https://github.com/python-pinot-dbapi/pinot-dbapi/blob/3cdea3c7cba1691b857833359cde20b0cd0c80d0/pinotdb/sqlalchemy.py#L175-L186

If password is provided, this statement will print out the plaintext value. Could we update this log statement by removing or masking the password value?

Example log message

2024-03-25 16:16:24,916:INFO:pinotdb.sqlalchemy:Updated pinot dialect args from {'host': '<host>', 'port': 443, 'path': 'query/sql', 'scheme': 'https', 'verify_ssl': True, 'username': 'username', 'password': 'password', 'debug': False}