search

python-pinot-dbapi / pinot-dbapi

Python DB-API and SQLAlchemy dialect for Pinot
MIT License
19 stars 33 forks source link

Update doc with the correct key to use multistage engine #94

Open pudom16 opened 5 months ago

pudom16 commented 5 months ago

Using the docs, we were not able to get multistage engine working with sqlalchemy when using useMultistageEngine.

Example

https://github.com/python-pinot-dbapi/pinot-dbapi/blob/4d3ce83378166a0a63917377cc342d604319803e/README.md?plain=1#L53

https://github.com/python-pinot-dbapi/pinot-dbapi/blob/4d3ce83378166a0a63917377cc342d604319803e/README.md?plain=1#L56-L58

https://github.com/python-pinot-dbapi/pinot-dbapi/blob/4d3ce83378166a0a63917377cc342d604319803e/README.md?plain=1#L108-L111

Could we update the doc to use the correct key that will enable multistage engine?

It works when we used use_multistage_engine instead

xiangfu0 commented 5 months ago

Thanks for bringing this up! Do you want to submit a PR to fix this?