python-poetry / poetry-plugin-export

Poetry plugin to export the dependencies to various formats
MIT License
238 stars 53 forks source link

make use of locked markers in lock file version 2.1 and thereby avoid `dependency walk failed` #286

Open radoering opened 4 months ago

radoering commented 4 months ago

Resolves: #176 Resolves: #183 Requires: python-poetry/poetry#9427

With python-poetry/poetry#9427 we can fix dependency walk failed once and for all. The dependency walker becomes as simple as iterating over a flat list and doing some simple marker operations. There is no complicated erroneous logic anymore because the resulting markers for each locked package can be read from the lock file.

I adapted all tests so they are run with an old lock file without markers and with a new lock file with markers and added a test (at the end) that raises dependency walk failed for an old lock file and succeeds for a new lock file.

edgarrmondragon commented 4 months ago

This does resolve the long-standing issue with urllib3 for us: https://github.com/meltano/sdk/actions/runs/9358298538/job/25759841162.

jbw-vtl commented 4 months ago

Very interested, we have been having issues with urllib3 as well

sonarcloud[bot] commented 3 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
13.7% Duplication on New Code (required ≤ 12%)

See analysis details on SonarCloud

sonarcloud[bot] commented 5 days ago

Quality Gate Failed Quality Gate failed

Failed conditions
18.8% Duplication on New Code (required ≤ 12%)

See analysis details on SonarCloud