python-poetry / poetry

Python packaging and dependency management made easy
https://python-poetry.org
MIT License
31.09k stars 2.25k forks source link

Error when adding URL tar.gz #1836

Closed Yelinz closed 4 years ago

Yelinz commented 4 years ago

Issue

Poetry fails to add a URL tar.gz dependency.

$ poetry add -vvv https://github.com/projectcaluma/caluma/archive/v4.3.0.tar.gz
Using virtualenv: /home/yelin/.cache/pypoetry/virtualenvs/camac-UQggRNiR-py3.7

[RuntimeError]
Unable to determine the package name of /tmp/tmpfkl5pgzy/v4.3.0.tar.gz

Traceback (most recent call last):
  File "/home/yelin/.poetry/lib/poetry/_vendor/py3.7/clikit/console_application.py", line 131, in run
    status_code = command.handle(parsed_args, io)
  File "/home/yelin/.poetry/lib/poetry/_vendor/py3.7/clikit/api/command/command.py", line 120, in handle
    status_code = self._do_handle(args, io)
  File "/home/yelin/.poetry/lib/poetry/_vendor/py3.7/clikit/api/command/command.py", line 171, in _do_handle
    return getattr(handler, handler_method)(args, io, self)
  File "/home/yelin/.poetry/lib/poetry/_vendor/py3.7/cleo/commands/command.py", line 92, in wrap_handle
    return self.handle()
  File "/home/yelin/.poetry/lib/poetry/console/commands/add.py", line 89, in handle
    packages, allow_prereleases=self.option('allow-prereleases')
  File "/home/yelin/.poetry/lib/poetry/console/commands/init.py", line 294, in _determine_requirements
    requires = self._parse_requirements(requires)
  File "/home/yelin/.poetry/lib/poetry/console/commands/init.py", line 389, in _parse_requirements
    package = Provider.get_package_from_url(requirement)
  File "/home/yelin/.poetry/lib/poetry/puzzle/provider.py", line 466, in get_package_from_url
    package = cls.get_package_from_file(temp_dir / file_name)
  File "/home/yelin/.poetry/lib/poetry/puzzle/provider.py", line 246, in get_package_from_file
    'Unable to determine the package name of {}'.format(file_path)
finswimmer commented 4 years ago

Hello @Yelinz,

AFAIK the tar.gz must be a valid sdist package. This is not the case here. It contains just the project folder.

fin swimmer

Yelinz commented 4 years ago

Thanks @finswimmer !

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.