Closed danyeaw closed 4 years ago
+1
Would an acceptable solution to this be to turn off the virtualenv checks if virtualenvs.create = false
? If so, I can submit a PR.
Yes, turning off virtualenvs worked me.
I was able to reproduce this with 1.1.0a1. If one of the core devs could confirm that they think this would be an acceptable solution, I would be happy to submit a PR.
I have confirmed that this issue is now resolved in both 1.0.10 and 1.1.0b2. Thanks for the great library ❤️
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
[X] I am on the latest Poetry version.
[X] I have searched the issues of this repo and believe that this is not a duplicate.
[X] If an exception occurs when executing a command, I executed it again in debug mode (
-vvv
option).OS version and name: Windows 10 in MSYS2 MINGW64 shell
Poetry version: 1.0.2 through 1.1.0a1
Link of a Gist with the contents of your pyproject.toml file: https://github.com/gaphor/gaphor/blob/master/pyproject.toml
Issue
poetry install
always fails in MSYS2 with poetry > 1.0.0. This is a regression that was added in version 1.0.1 in PR #1797, since all previous versions including 1.0.0 didn't have this issue. I am using MSYS2 so that I can build my GTK app in Windows.Poetry has never worked to create virtualenvs in MSYS2, and that is fine since I am OK managing my own virtualenv. The settings are:
Poetry added functionality to check whether the venv is valid, and even though I have a venv that is working fine, poetry detects it as broken. Ironically, poetry then breaks the venv by trying to remove it and recreate it which fails.
I would expect that poetry's behavior would be to turn off virtualenv functionality when
virtualenvs.create = false
. That options means to me that I don't want poetry to manage virtualenvs, so it doesn't make sense to me why poetry would try to check if the virtualenv is valid, or try to recreate a virtualenv.