python-poetry / poetry

Python packaging and dependency management made easy
https://python-poetry.org
MIT License
30.92k stars 2.25k forks source link

tox support #222

Closed sobolevn closed 6 years ago

sobolevn commented 6 years ago

Hi, thanks for this awesome package. It look really promising.

Here's my problem: I am using tox and pyproject.toml for my library. When trying to use them together that's what happens:

» tox
ERROR: No setup.py file found. The expected location is:
  /Users/sobolev/Documents/github/mimesis-factory/setup.py
You can
  1. Create one:
     https://packaging.python.org/tutorials/distributing-packages/#setup-py
  2. Configure tox to avoid running sdist:
     http://tox.readthedocs.io/en/latest/example/general.html#avoiding-expensive-sdist

What is the recommended solution for this workflow? The only thing that I do not want to do is returning to the old setup.py.

rcisterna commented 6 years ago

Hi, I'm in the same situation here. It seems like this is a tox issue, which depends on a pip issue.

I really hope that all this awesome tools implements PEP-517 and PEP-518 soon.

sdispater commented 6 years ago

For now, you can use poetry with tox by using something similar to what I did in pendulum: https://github.com/sdispater/pendulum/blob/master/tox.ini

vberlier commented 6 years ago

Thanks a heap I was just wondering how tox would work without any setup.py. Perfect timing!

valignatev commented 6 years ago

If we'd think about setup.py as some kind of a lock file which you never generate by hand, maybe an option for poetry lock which generates setup.py might be helpful. Of course, it doesn't work for those who want to avoid storing setup.py in their repo. Just brainstorming here.

cs01 commented 6 years ago

@valignatev this was suggested in https://github.com/sdispater/poetry/issues/191

tadeoos commented 6 years ago

I think it would be a good idea to add the pendulum example to FAQ (or start a wiki?)

tadeoos commented 6 years ago

I think we can close this issue for now

sobolevn commented 6 years ago

Yeap, #227 solves the problem. Thanks everyone!

mlissner commented 2 years ago

For those arriving here, the solution mentioned in #227 is this link: https://python-poetry.org/docs/faq/#is-tox-supported

github-actions[bot] commented 5 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.