python-poetry / poetry

Python packaging and dependency management made easy
https://python-poetry.org
MIT License
31.17k stars 2.25k forks source link

Poetry doesn't install github .tar.gz file but goes to pypi. #2527

Closed rvanlaar closed 2 years ago

rvanlaar commented 4 years ago

Issue

Poetry installs the original google charts wrapper from pypi instead of our version pinned via a tar.gz link.

Specifically: This package is installed: https://github.com/kiesopmaat/google-chartwrapper as a source package via this link: https://github.com/kiesopmaat/google-chartwrapper/archive/e7bd81713daf0e4700e2c5bff56f5fdec0b15940.tar.gz

What happens is that poetry installs the 0.7 version package from PyPI.

sdispater commented 4 years ago

Poetry properly installs the package from the url (you can check your lock file which references the url).

The issue here is Poetry tries to retrieve the package version from the PKGINFO file which has this line Version: 0.7 that's why it's reporting the version 0.7 being installed.

rvanlaar commented 4 years ago

It actually installs version 0.7, no joke.

I get hit by this bug. It loads python2 code, due to its python3 check is being: sys.version.startswith('3.0') Which fails with python3 versions higher then > 3.0.

https://github.com/appknox/google-chartwrapper/blob/4db3543c41205e1479fb5b2665672b12c3069cba/GChartWrapper/constants.py#L8

neersighted commented 2 years ago

There's no reported Poetry version and this issue has long been stale -- I am going to close it now. Please open a new issue with a reproduction if you believe this happens in a supported version of Poetry.

rvanlaar commented 2 years ago

I just checked. This bug is no longer in poetry.

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.