Closed fmagin closed 2 years ago
@fmagin can you try the fix at https://github.com/python-poetry/poetry-core/pull/368#issue-1246356001 please?
@abn yep that fix works! I searched the previous issues for setup.cfg
and didn't find any, so I didn't realize there was such a recent issue/PR for this already
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
[x] I am on the latest Poetry version.
[x] I have searched the issues of this repo and believe that this is not a duplicate.
[x] If an exception occurs when executing a command, I executed it again in debug mode (
-vvv
option).OS version and name: Arch Linux
Poetry version:
1.2.0b1
Link of a Gist with the contents of your pyproject.toml file: https://github.com/angr/angr-dev/blob/28531802747918c5610e3e5f239d98eb9015afd4/pyproject.toml
Issue
the angr project has various subprojects that only have a
setup.cfg
file and nosetup.py
file. This results in poetry throwing an exception when trying to use them as a local path package: i.e.Directory /home/fmagin/Projects/angr-dev/archinfo does not seem to be a Python package
. inpoetry/core/packages/directory_dependency.py:54
. Specifically this happens because the check only checks if asetup.py
exists or if thepyproject.toml
hastool.poetry
keys. Both aren't true for the angr subprojects. If I edit the poetry source code and add a check for the existence ofsetup.cfg
file then poetry works as expected (and like if I had specified the dependency as a pinned git commit from GitHub directly), so I am considering this a bug