python-poetry / poetry

Python packaging and dependency management made easy
https://python-poetry.org
MIT License
31.64k stars 2.27k forks source link

Poetry fails when runs pre-commit hooks in windows-2022 [GitHub Actions] #8180

Closed irux closed 8 months ago

irux commented 1 year ago

Issue

Poetry fails when runs pre-commit hooks in GitHub Windows Actions when the poetry version is 1.5.1. This doesn't happen in lower minor versions. Here you can see an example of the error: https://github.com/bakdata/kpops/actions/runs/5517162002/jobs/10059409230

Secrus commented 1 year ago

How did you pinpoint the poetry to be at fault? From the log you linked, I would say that pre-commit or virtualenv are more likely to be at fault, since the error origins from subprocess.

irux commented 1 year ago

How did you pinpoint the poetry to be at fault? From the log you linked, I would say that pre-commit or virtualenv are more likely to be at fault, since the error origins from subprocess.

@Secrus thank you for your response. The reason to think about it (maybe it is wrong) was to see that this error doesn't happen when the version is lower than 1.5.1. But you have a good point, maybe (and high probably) it is a pre-commit problem. I will open an issue there :)

Secrus commented 1 year ago

Well, I am gonna keep the issue open for now, but my take is that either virtualenv or pre-commit are at fault, since I don't see where Poetry would fall in the call stack.

Secrus commented 8 months ago

Since you didn't come back to the issue, I assume it was resolved. If it still exists, please open a new report.