python-poetry / poetry

Python packaging and dependency management made easy
https://python-poetry.org
MIT License
31.61k stars 2.26k forks source link

Expose git errors instead of printing a generic error message #9819

Open amirebrahimi opened 1 day ago

amirebrahimi commented 1 day ago

Issue Kind

Change in current behaviour

Description

Currently, if there are any git errors when run as a subprocess, the following error will be presented to the user: Failed to clone <git repo>, check your git configuration and permissions for this repository

Impact

This can be misleading to the user in one case we've found, which is when long filename support needs to be enabled. What would be ideal is if the error message from git is exposed to the user.

Workarounds

Enabling long filename support and setting git config --system core.longpaths true fixes the issue, but a user wouldn't know to do that unless they dug in further.

dimbleby commented 1 day ago

make a merge request!