fix: Significant slowdown on nested tables depending on syntax

python-poetry / tomlkit

Style-preserving TOML library for Python

MIT License

693 stars 98 forks source link

fix: Significant slowdown on nested tables depending on syntax #324

Closed frostming closed 11 months ago

frostming commented 12 months ago

Fixes #193 Fixes #301 Fixes #319

Signed-off-by: Frost Ming me@frostming.com

frostming commented 12 months ago

With this change, I observed a 4x faster parsing the file given in #319 . Further improvement may need a rewrite on a large scale.

@davemc0 is this acceptable from your side?

davemc0 commented 12 months ago

Thank you! This is very much appreciated. I'm not sure it will bring all use cases into the acceptable range since some were six minutes, but it will definitely enable several of our use cases.

Thanks again.