python-qds / qdscreen

Quasi-determinism screening for fast Bayesian Network Structure Learning (from T.Rahier's PhD thesis, 2018)
https://python-qds.github.io/qdscreen/
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Remove `pyitlib` dependency in order to master (and possibly accelerate) entropy computations #33

Open smarie opened 1 year ago

smarie commented 1 year ago

Currently we use the following functions in pyitlib:

It would be great to include functions directly in our code so as to not rely on an external dependency "just for 2 functions". Also another interesting thing is that we could compile it, for example as shown here: https://gist.github.com/kudkudak/dabbed1af234c8e3868e

This migh tbe related to #29

smarie commented 1 year ago

Also another reason for embedding these, would be to better control how nans are handled. See #34