python-qt-tools / PyQt5-stubs

Stubs for PyQt5
GNU General Public License v3.0
66 stars 31 forks source link

Correct annotations for signals in QThread and QNetworkAccessManager #129

Closed TilmanK closed 3 years ago

TilmanK commented 3 years ago

Hey, is there anything else you need for this PR? You'll squash it anyway, so the credentials won't matter, right?

altendky commented 3 years ago

@TilmanK, I personally prefer to do a regular merge generally. If you would prefer a squash to get rid of the commit name/email, we can.

TilmanK commented 3 years ago

Ah, sorry! I totally forgot that I wanted to rebase the commits. Anyway, next time then... Thanks for accepting the PR.