Closed altendky closed 3 years ago
I guess I may as well provide the to-be-uploaded files here. These were built from 2aa40a95fd060a7407baa58ed3af9125d81ca1ca. If approved, that will be the commit to get tagged as 5.15.2.0
.
(thanks GitHub for making me pretend these are .txt
files...)
PyQt5_stubs-5.15.2.0-py3-none-any.whl.txt
PyQt5-stubs-5.15.2.0.tar.gz.txt
To confirm, this would get merged into master, we'd tag the commit, and CI will be expected to build/deploy the wheels?
Yes, no, and no. As per the present plan. It would get merged into master after adding the guessed next release number to the changelog (or could be just [unreleased]
leaving the version number un-guessed). The tag would be applied to the commit on the branch mentioned above (2aa40a95fd060a7407baa58ed3af9125d81ca1ca). At present, CI doesn't even archive a wheel and sdist, let alone publish it.
https://github.com/python-qt-tools/PyQt5-stubs/issues/115#issuecomment-779538224
More automation would be nice and might follow at some point, but I don't think we ought to wait for it to release.
So then where did the files you attached come from? Did you manually make them? Will you be manually pushing them to PyPI?
A local copy of the repo at the linked commit with a run of git clean -ffdx
then env creation and python -m build --sdist --wheel
to build them. Yes manual creation and pushing is proposed for now.
Yay! :tada:
It looks like you didn't create a release on GitHub, so I took the freedom to do so.
Yeah, that's on the list of things I haven't gotten myself familiar with. I think I've seen pushing a tag create a draft release? Then you can go and copy the changelog in as a message and make a final release? Looks like it could afford to have the sdist and wheel added?
Closes #115.