python-qt-tools / PyQt5-stubs

Stubs for PyQt5
GNU General Public License v3.0
66 stars 31 forks source link

PyQt dependency #158

Closed analog-cbarber closed 3 years ago

analog-cbarber commented 3 years ago

It appears that this package depends on PyQt itself. Normally this would not be a problem, but when I pip install this package into a conda environment that already has PyQt5 (5.12.3), it does not recognize that distribution and starts to download it again from pypi.

I can install using --no-deps but it would be nicer if there was no explicit package dependency.

The-Compiler commented 3 years ago

It appears that this package depends on PyQt itself.

Can you elaborate? The setup.py only declares a dependency on PyQt5 for tests.

analog-cbarber commented 3 years ago

Hmm. I just did a pip install into my conda environment and it started to download and install pyqt5 as well.

analog-cbarber commented 3 years ago

Actually, this might just be a problem with the 5.12 release of Qt, which is what we are currently using.

I assume that 5.12 is what you need to go with the corresponding PyQt5 release?

The-Compiler commented 3 years ago

The dependency was removed in 02a0b6174ff6c7c6ca9f982947b8698c34c85537 for #25, so this was fixed for the 5.14.1.0 release.