search

python-qt-tools / PyQt5-stubs

Stubs for PyQt5
GNU General Public License v3.0
66 stars 31 forks source link

Fix of all signals. Script to annotate signals automatically. #162

Closed TilmanK closed 2 years ago

bluebird75 commented 2 years ago

I love the approach and I have been using CST as well for annotating QFlags better.

I am worried though because your changes have marked incorrectly a method as a signal :

QtWidgets.QGraphicsScene :

focusOnTouch is actually a property (see https://doc.qt.io/qt-5/qgraphicsscene.html) . If this one was marked incorrectly, there could be others. Could you investigate this particular case and see if it is a general problem or maybe just a PyQt5 stubs bug. While working with QFlags and CST, I have found a few buggy generated classes.

Quick reviewing the changes did not reveal anything else.

bluebird75 commented 2 years ago

I checked again. Actually, focusOnTouch is already incorrectly declared as a signal, it has nothing to do with your script. So, I'll complete the review and organize the merging.