search

python-qt-tools / PyQt5-stubs

Stubs for PyQt5
GNU General Public License v3.0
68 stars 31 forks source link

Lock master and upstream branches #80

Closed altendky closed 2 years ago

altendky commented 4 years ago

Do we have the master branch locked down? I like it to be locked both to avoid accidents and force PRs so there is review. Depending on the release workflow there can be conflicts, but... Opinions? Once we get CI passing we can require it to pass for merges as well. Oh, probably both master and upstream in the case of this repo.

BryceBeagle commented 4 years ago

I'm a fan of locking main-line branches and enforcing the PR workflow

altendky commented 4 years ago

Now we've got master green in CI, we probably mostly want to keep it that way? So the branch could be set to require Travis passing. @stlehmann, opinions? upstream could be locked from direct pushes but is expected to fail CI (unless we adjust it) so it wouldn't get set to require Travis passing.

altendky commented 4 years ago

Oh yeah, I also like requiring that PR branches are up to date. Bonus, this gets you a button on the PR page to have GitHub do the update merge for you easily.

bluebird75 commented 2 years ago

So, if everybody here agrees that it's a good idea to lock master, I guess you can take care of it ...

bluebird75 commented 2 years ago

This seems no longer relevant. closing