python-restx / flask-restx

Fork of Flask-RESTPlus: Fully featured framework for fast, easy and documented API development with Flask
https://flask-restx.readthedocs.io/en/latest/
Other
2.16k stars 335 forks source link

Support configurable OAUTH redirect URLs #438

Open thedumbterminal opened 2 years ago

thedumbterminal commented 2 years ago

Is your feature request related to a problem? Please describe. Currently when using oauth the redirect URL is hardcoded here:

https://github.com/python-restx/flask-restx/blob/master/flask_restx/templates/swagger-ui.html#L55

The included oauth2-redirect.html is fine unless you are implementing OAUTH on the server side where you need logic such as creating a user account etc.

Describe the solution you'd like I'd like to set my own OAUTH redirect URL so after the OAUTH dance I can create user accounts, for example using flask-security. This could be done via an flask app config setting.

Describe alternatives you've considered Did briefly consider how to redirect the default swagger redirect URL, but it seems wrong to use it for anything other than documentation needs.

Additional context Example of using flask-dance for oauth to allow specific OAUTH handlers:

https://github.com/singingwolfboy/flask-dance-github

I've got a working branch here, which I can submit a PR for if the feature is accepted:

https://github.com/python-restx/flask-restx/compare/master...thedumbterminal:oauth-redirect?expand=1

zachanator070 commented 2 years ago

Ran into this exact same problem today, hope to see a fix.

thedumbterminal commented 2 years ago

Just raised the PR for the branch with my change in the hope that it gets noticed.

thedumbterminal commented 2 years ago

Hi @j5awry are you able to give any feedback on this issue, or review the linked PR? Thanks.

thedumbterminal commented 1 year ago

HI @ziirish are you take a review on the PR or point me in the direction of someone else who can? thanks

thedumbterminal commented 8 months ago

@peter-doggart are you able to review this?

peter-doggart commented 7 months ago

@thedumbterminal This is on my to-do list. Just haven't had a chance to do any updates lately, but I will make sure this makes it into the next release.

thedumbterminal commented 7 months ago

Thanks 🙏