Closed Ryu-CZ closed 9 months ago
Thanks for doing this @Ryu-CZ
I'm assuming this is held up by the pytest-flask
issue?
@peter-doggart yes, tests are not passing because pytest-flask
issue 167
I forgot to add my method into utils.__all__
so here is small patch to fix it. This should prevent static syntax analyses to show weak warning about Importing method not listed in all.
Still waiting on the pytest fixes, but it looks like they are working on getting that project updated. :)
Attention: 9 lines
in your changes are missing coverage. Please review.
Comparison is base (
3ea4ce1
) 96.45% compared to head (81dd9f4
) 96.15%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I forget to mention the new method import_check_view_func
to get _endpoint_from_view_func
is compatible with flask
reasonable versions 1, 2, 3.
Due to repeated accident of import error #567 I added helper method _import_check_viewfunc . With fallback to last known implementation which stayed the same in all flask versions.
I submit new pull request with new branch name
flask-scaffold_567
on same commit, because in original pull request #568 I usedmaster
branch in contrary to guidelines.