python-restx / flask-restx

Fork of Flask-RESTPlus: Fully featured framework for fast, easy and documented API development with Flask
https://flask-restx.readthedocs.io/en/latest/
Other
2.16k stars 335 forks source link

Add flask 2 (<3.0) and flask 3 (>=3.0) to test matrix and do not fast fail #577

Closed foarsitter closed 11 months ago

foarsitter commented 1 year ago

To get more insight if our fixes are working for both flask version I created a test-matrix for flask 2 (<3.0.0) & flask 3 (>=3.0.0)

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a65dbe7) 96.15% compared to head (8bcd332) 96.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #577 +/- ## ======================================= Coverage 96.15% 96.15% ======================================= Files 20 20 Lines 2756 2756 ======================================= Hits 2650 2650 Misses 106 106 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

peter-doggart commented 1 year ago

Great idea! Hopefully the team over at pytest-flask will have an updated version soon. We should probably leave this in going forwards for a bit to ensure we don't break backwards compatibility too anyways though!

foarsitter commented 1 year ago

Looks like the problems with pytest-flask are solved since the Actions are succeeding :+1:

cthoyt commented 1 year ago

@peter-doggart it looks like this is working, I hope it can be merged soon!