python 3 error: `basestring` is still used by ropemode

python-rope / ropemode

Common parts of ropemacs and ropevim.

GNU Lesser General Public License v3.0

15 stars 12 forks source link

python 3 error: `basestring` is still used by ropemode #15

Closed glyph closed 5 years ago

glyph commented 5 years ago

I have been mostly happily using ropemode with Emacs, but today I set ropemacs-autoimport-modules and got a pymacs traceback because there's an isinstance(..., basestring) in the autoimport cache generation code path.

soupytwist commented 5 years ago

Fixed in #16

glyph commented 5 years ago

@soupytwist Thanks so much for the update! Any chance this will result in a PyPI release soon?

glyph commented 5 years ago

(Also possibly worth noting, this furthers #8 along … :))

soupytwist commented 5 years ago

I haven't released this one before myself, I can take a look at it unless @mcepl wants to.

mcepl commented 5 years ago

Fixed in #14 .

glyph commented 5 years ago

Thanks @soupytwist, @mcepl !