search

python-rope / ropevim

vim mode that uses rope library to provide features like python refactorings and code-assists
GNU General Public License v2.0
245 stars 34 forks source link

Added bundle path manually to PYTHONPATH #34

Closed AitorATuin closed 9 years ago

AitorATuin commented 9 years ago

Changes to make it work on macosx using macvim.

Issue related: #33

mcepl commented 9 years ago

I am not sure about this. We have in README:

First add ropevim folder to the PYTHONPATH (or install it using python setup.py install).

so strictly speaking this is not a bug, because you don't follow the documentation. My primary envisioned mean of the installation was pip install ropevim and automagic manipulation with sys.path behind user’s back makes me nervous. But I see that the ropevim sits in the rather unhappy position in between vim plugin (for which standard installation is using pathogen these days) and Python module, which makes the decision difficult. I would rather go other way and fix setup.py to install properly the vim plugin part correctly.

Otherwise, thank you a lot for doing a Mac testing (which we sorely need) and providing a pull request.

What do you think?

AitorATuin commented 9 years ago

Being honest, i dont like the idea of manipulating the path so this evening i will take a look to it again.

AitorATuin commented 9 years ago

Closing, i agree with you, its better to use another solution :)