search

python-rope / ropevim

vim mode that uses rope library to provide features like python refactorings and code-assists
GNU General Public License v2.0
245 stars 34 forks source link

"Project not exists" dialog improvements / bug fix #47

Closed yggdr closed 8 years ago

yggdr commented 8 years ago

(From #36) When creating a new rope project, the UI dialog "Project not exists in $DIR, create one?" expects the user to type "yes". Even "Yes" will abort the process. Doing so generates a notice "Project creation aborted", but also a python AttributeError. Given the formatting of the notice and the glaring red python error message, one might overlook the notice and assume an installation problem with Rope.

Please make the notice more readable, esp. by fixing the python error. Also make the dialog accept lower- and uppercase "yes", 'y', and an empty string as positiv answer.

Thank you.

andrewmichaelsmith commented 8 years ago

I get this, I assume I can push "y" and get a funny error about 'NoneType' object has no attribute 'pycore'

mcepl commented 8 years ago

I get this, I assume I can push "y" and get a funny error about 'NoneType' object has no attribute 'pycore'

Yes, it is confusing. You have to press "0" (that's zero) for creation of new rope project.

andrewmichaelsmith commented 8 years ago

Typing "yes" also seems to work fine (I've got my fix, just effectively +1ing with a bit of explanation :))

mcepl commented 8 years ago

If anybody has any comments on this pull request, please, speak up!