search

python-rope / ropevim

vim mode that uses rope library to provide features like python refactorings and code-assists
GNU General Public License v2.0
249 stars 34 forks source link

Create virtualenv to install ropevim #86

Closed rdbisme closed 3 years ago

rdbisme commented 3 years ago

Hello, this PR shamelessly steals the virtualenv logic from black in order to create a virtualenv in which to install ropevim (instead of requiring to install it system wise)

mcepl commented 3 years ago

Do you want to say that every user of ropevim is forced to use virtualenv for it? Is there some configuration option (defaulting to off) to control this behaviour? If the answers are yes and no, then I would reject this PR.

rdbisme commented 3 years ago

Yes, but I think it's the way to go. ropevim is not packaged for example on ArchLinux, and using pip install systemwise is not at all a habit I'd like to endorse. I think the best practice is to install system packages using the packaging system and never use sudo with pip.

Anyway, that's what they do with black vim plugin and I think it's a good thing. You isolate the things you need for the vim plugin to work in a virtualenv with less chance to mess up.

mcepl commented 3 years ago

pip install --user?

rdbisme commented 3 years ago

Mmh, yeah. I still prefer virtualenvs but probably yes, that would solve it. It's probably an easier solution... I don't know then why in Black they use a virtualenv.

rdbisme commented 3 years ago

One advantage of this approach is that installs automatically when installing the plugin without further user action required

mcepl commented 3 years ago

Let me reject this now.