search

python-scim / scim2-models

SCIM resources serialization and validation with Pydantic
https://scim2-models.readthedocs.io
Apache License 2.0
11 stars 3 forks source link

Example SCIM provider #56

Closed ccoors closed 3 months ago

ccoors commented 4 months ago

~This is the current state of my example SCIM provider WSGI application.~

Moved implementation to scim2-server. Added as submodule here.

azmeuk commented 4 months ago

Hi @ccoors Thank you for your contribution! I will try to gather enough time to review your PR in the coming days/weeks.

ccoors commented 4 months ago

I have managed to implement PATCH :) Now working on Sorting and will probably also do Bulk.

azmeuk commented 4 months ago

Hi. I still could not find much time for reviewing your work, but I don't lose hope!

ccoors commented 3 months ago

Hi. I still could not find much time for reviewing your work, but I don't lose hope!

No worries! Just today we reached an "acceptable" state. Apart from Bulk (which we won't implement for the time being) everything works well enough for our use-case. We also tested this exact example provider against Microsoft Entra and could verify that it works.

Our main motivation for merging this example into this repo is to ensure it "stays green" with any changes to scim2-models. As I said, if you're not happy with the example that's totally fine too, we can move it to our own repo.

azmeuk commented 3 months ago

I was thinking that maybe we could add your example server implementation in another repo. To keep the codebase synchronized with scim2-models, we could then add it as a subrepository here. If it is good for you, I will create a scim2-example-server repository and give you commit permissions. What do you think?

ccoors commented 3 months ago

Yes, that sounds fine. Git submodules are a bit annoying to work with, but in this instance I guess it's okay.

azmeuk commented 3 months ago

Ok. I invited you on https://github.com/yaal-coop/scim2-server

ccoors commented 3 months ago

@azmeuk I added the server in scim2-server and modified this PR, so that it uses it as a submodule. I'm not sure this will provide an 'easy' workflow for future changes in scim2-models, as you may have to synchronize changes across two repos. Maybe try it out for now?

azmeuk commented 3 months ago

Closing in favor of #71