search

python-sdbus / python-sdbus-networkmanager

python-sdbus binds for NetworkManager
GNU Lesser General Public License v2.1
30 stars 6 forks source link

Fix ConnectionType for "gsm" to match DeviceType.MODEM #40

Closed bernhardkaindl closed 2 years ago

bernhardkaindl commented 2 years ago

@igo95862: Apply the same kind of fix like in #36 for ETHERNET where we fixed ConnectionType.ETHERNET to match DeviceType.ETHERNET:

Use ConnectionType.MODEM to match DeviceType.MODEM for use with getattr() like shown in #36: getattr(ConnectionType, "MODEM").

Like with the rename from .WIRED to .ETHERNET in #36, this rename from .GSM to .MODEM is ok because the Enum ConnectionType is new, and wasn't in a release of this library yet.

bernhardkaindl commented 2 years ago

(I fixed the commit message twice and didn't change the commit. This is why the Compare button does not show a change.)