Open Regela opened 1 year ago
Hello,
I think there is a PPPOE
device type defined, however, it is probably the wrong name:
Can you try renaming it to PPP = "ppp"
?
No, PPOE and PPP it is a different things. I add PPP = "ppp" to ConnectionType enum and it solved my problem. Please, add it in repo )
Hmmm...
Looking at the NetworkManager source code it looks like the PPP device connection setting type should be "pppoe"?
The NM_SETTING_PPP_SETTING_NAME
seems to be almost unused anywhere in the source code.
Ok I think I get it.
So the Device D-Bus interface returns the 23
which in the DeviceType
enum has a name PPP
.
However, the PPP Device requires the Connection Settings type field set to "pppoe"
so the correct value should be PPP = "pppoe"
.
However, the ConnectionType
enum should probably be a map named REQUIRED_CONNECTION_SETTING_TYPE
and it won't cover all device types as it seems that certain device types can support multiple connection settings.
For example, VETH:
Hello! I need to add PPP Connection type to sdbus_async/networkmanager/enums.py It is a pptp vpn by network-manager-pptp
Thank you for excellent library!