search

python-sdbus / python-sdbus-networkmanager

python-sdbus binds for NetworkManager
GNU Lesser General Public License v2.1
30 stars 6 forks source link

Version inconsistency problem having to do with DeviceCapabilitiesFlags/DeviceCapabilities #62

Closed marcsmerlin closed 9 months ago

marcsmerlin commented 9 months ago

I just wanted to bring a what I think is a small version inconsistency problem to your attention. I installed the module using:

pip install --only-binary ':all:' sdbus-networkmanager

as suggested. When trying to run examples/block/device-state,py, reference to DeviceCapabilitiesFlags is unresolved. This is corrected by changing it to DeviceCapabilities which apparently existed in a previous version.

igo95862 commented 9 months ago

Hello @marcsmerlin

The version uploaded to PyPI is the 2.0.0

So the examples must be used from the 2.0.0 version: https://github.com/python-sdbus/python-sdbus-networkmanager/tree/2.0.0/examples

Right now the 3.0.0 is under development. The examples for version 3.0.0 are not going to work on 2.0.0

I should probably add a disclaimer.

igo95862 commented 9 months ago

I separated the examples by version in commit 76b9141b3e4a5dc169ec8c27c63a91d9b09029b5. Hopefully it will be self explanatory which examples should be ran against which version. @marcsmerlin could you give it a test that device-state.py example from 2.0.0 folder works with PyPI version?

marcsmerlin commented 9 months ago

It works just fine. Thanks!

On Sun, Feb 11, 2024 at 1:30 PM igo95862 @.***> wrote:

I separated the examples by version in commit 76b9141 https://github.com/python-sdbus/python-sdbus-networkmanager/commit/76b9141b3e4a5dc169ec8c27c63a91d9b09029b5. Hopefully it will be self explanatory which examples should be ran against which version. @marcsmerlin https://github.com/marcsmerlin could you give it a test that device-state.py example from 2.0.0 folder works with PyPI version?

— Reply to this email directly, view it on GitHub https://github.com/python-sdbus/python-sdbus-networkmanager/issues/62#issuecomment-1937831979, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASOQIIOPVAXZ236XYUJYJ6TYTEE5BAVCNFSM6AAAAABC3D7XBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXHAZTCOJXHE . You are receiving this because you were mentioned.Message ID: @.***>

igo95862 commented 9 months ago

Great!