+AuthException at mediawiki.py' access_token

albertoleoncio commented 2 months ago

+AuthException at access_token

Proposed changes

Errors can also occur at this step (in my case, I have been receiving signature failure errors). Without this exception, the library just returns a generic "NoneType object is not subscriptable" error and the OAuth error code is not displayed.

Types of changes

Please check the type of change your PR introduces:

[ ] Release (new release request)
[X] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (PEP8, lint, formatting, renaming, etc)
[ ] Refactoring (no functional changes, no api changes)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Build related changes (build process, tests runner, etc)
[ ] Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[X] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added documentation to https://github.com/python-social-auth/social-docs

Other information

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.76%. Comparing base (61d58d6) to head (edb16ef).

Files	Patch %	Lines
social_core/backends/mediawiki.py	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #900 +/- ## ========================================== - Coverage 77.77% 77.76% -0.02% ========================================== Files 347 347 Lines 10606 10608 +2 Branches 699 700 +1 ========================================== Hits 8249 8249 - Misses 2200 2202 +2 Partials 157 157 ``` | [Flag](https://app.codecov.io/gh/python-social-auth/social-core/pull/900/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-social-auth) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/python-social-auth/social-core/pull/900/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-social-auth) | `77.76% <0.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-social-auth#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nijel commented 2 months ago

Merged, thanks for your contribution!

python-social-auth / social-core