python-social-auth / social-core

Python Social Auth - Core
BSD 3-Clause "New" or "Revised" License
837 stars 543 forks source link

Fix https://github.com/python-social-auth/social-core/issues/918 #921

Closed Fleapse closed 1 week ago

Fleapse commented 1 week ago

Make username always a string to avoid errors in the user pipeline.

Proposed changes

Bugfix https://github.com/python-social-auth/social-core/issues/918

Types of changes

Please check the type of change your PR introduces:

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Other information

I was unable to build the make tests docker image everything ended in error failed to solve: process "/bin/sh -c /pyenv.sh" did not complete successfully: exit code: 1

I’m not sure what this is connected with (perhaps due to the blocking of the docker hub in Russia or something else, but because of this I could not run the tests)

upd: dont know how, but after rerun docker compose run social-tests tests works

  py38: OK (47.50=setup[10.21]+cmd[2.90,34.39] seconds)
  py39: OK (44.02=setup[6.38]+cmd[3.03,34.61] seconds)
  py310: OK (42.92=setup[6.09]+cmd[2.95,33.88] seconds)
  py311: OK (44.56=setup[5.40]+cmd[4.35,34.81] seconds)
  py312: OK (48.56=setup[7.95]+cmd[4.62,35.99] seconds)
  congratulations :) (227.62 seconds)
nijel commented 1 week ago

Merged, thanks for your contribution!