python-social-auth / social-core

Python Social Auth - Core
BSD 3-Clause "New" or "Revised" License
851 stars 545 forks source link

Allow overriding emails to be fully lowercase #943

Closed selten closed 1 day ago

selten commented 5 days ago

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

Please check the type of change your PR introduces:

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Other information

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.88%. Comparing base (e294f03) to head (326d4b3). Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
social_core/tests/actions/actions.py 66.66% 0 Missing and 2 partials :warning:
social_core/pipeline/user.py 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #943 +/- ## ========================================== + Coverage 77.86% 77.88% +0.02% ========================================== Files 347 347 Lines 10653 10669 +16 Branches 706 504 -202 ========================================== + Hits 8295 8310 +15 + Misses 2201 2200 -1 - Partials 157 159 +2 ``` | [Flag](https://app.codecov.io/gh/python-social-auth/social-core/pull/943/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-social-auth) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/python-social-auth/social-core/pull/943/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-social-auth) | `77.88% <81.25%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-social-auth#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gersona commented 1 day ago

Looks good, Would you also be able to submit a PR to the social-docs repository to update the documentation ? That would sit in the Miscellaneous settings section of the settings.rst