search

python-sprints / python-sprints.github.io

Python Sprints website
https://python-sprints.github.io/
12 stars 55 forks source link

Main website #68

Closed sukanyamandal closed 6 years ago

sukanyamandal commented 6 years ago

Updated the time and location details for PyData Mumbai.

datapythonista commented 6 years ago

Amazing, do you main updating the coordinates (latitude and longitude) too? Otherwise the marker will be in the wrong place. Thanks!

sukanyamandal commented 6 years ago

No I did not make any change in the latitude and longitude. I checked from google and there seem to be only 0.01 difference. Hence did not make an effort to change.

datapythonista commented 6 years ago

Ok, cool, thank you!

sukanyamandal commented 6 years ago

Thanks to you too! :)

datapythonista commented 6 years ago

I think the geo is 7 kms far away from the event address, up to you, but I think it may be confusing for people attending the event. I'd fix it.

Also, it'd be a good practice for using branches, you shouldn't open pull requests from master. In a best case scenario everything will work fine, like in this case, but in many circumstances you'll end up in situations where it's difficult to continue working in some changes, and you need to start again.

I'm preparing a screencast explaining all the concepts regarding pull requests, as they are tricky.