search

python-telegram-bot / ptbtest

GNU General Public License v3.0
50 stars 28 forks source link

Fix tests #14

Open j-maas opened 6 years ago

j-maas commented 6 years ago

Just some quick and naive fixes to make the tests pass.

codecov[bot] commented 6 years ago

Codecov Report

Merging #14 into master will decrease coverage by 0.21%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   99.68%   99.46%   -0.22%     
==========================================
  Files          11       11              
  Lines         939      941       +2     
==========================================
  Hits          936      936              
- Misses          3        5       +2
Impacted Files Coverage Δ
ptbtest/usergenerator.py 100% <ø> (ø) :arrow_up:
ptbtest/mockbot.py 99.48% <100%> (ø) :arrow_up:
ptbtest/messagegenerator.py 99.28% <0%> (-0.72%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d931aa...7156b5d. Read the comment docs.

codecov[bot] commented 6 years ago

Codecov Report

Merging #14 into master will decrease coverage by 0.21%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   99.68%   99.46%   -0.22%     
==========================================
  Files          11       11              
  Lines         939      941       +2     
==========================================
  Hits          936      936              
- Misses          3        5       +2
Impacted Files Coverage Δ
ptbtest/usergenerator.py 100% <ø> (ø) :arrow_up:
ptbtest/mockbot.py 99.48% <100%> (ø) :arrow_up:
ptbtest/messagegenerator.py 99.28% <0%> (-0.72%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d931aa...bca2e2b. Read the comment docs.

j-maas commented 6 years ago

The build only fails on Python 2.7 and PyPI. I have added an __init__.py to PtbMock which I hope solves the issue, but of course this doesn't trigger a rebuild here. @Eldinnie, could you prompt Travis to rebuild, please?

Bibo-Joshi commented 2 years ago

Hi. I'm notifying everyone who PRed to this repo about #21.