search

python-telegram-bot / rules-bot

The Telegram bot @roolsbot serves the python-telegram-bot group chats by announcing the rules.
https://t.me/roolsbot
GNU Affero General Public License v3.0
127 stars 51 forks source link

Remove bot.ini, create dummy file instead? #100

Closed lemontree210 closed 1 year ago

lemontree210 commented 1 year ago

I think git might get confused by the fact that bot.ini is at the same time checked into the repo and includes in .gitignore. By default, my IDE tried to commit bot.ini with my tokens.

Maybe it would be better to remove bot.ini from the repo and create something like bot_example.ini?

Also, it could be useful to include Bearer in this example file, just for the sake of clarity. The 6-digit code was a bit confusing to me.

I could do that if that sounds reasonable.

Bibo-Joshi commented 1 year ago

Hi. Yes, that's something that one can do 👍 One could also make sure that the Bearer prefix is just added if missing. Feel free to PR :)

lemontree210 commented 1 year ago

I tried to add this prepending with Bearer to graphqlclient.py but can't commit because pylint is not happy with existing code :) Here's the output.

I can just go without automatic prepending of Bearer or maybe there's a way to force commit without pylint checks passing.

Poolitzer commented 1 year ago

@lemontree210 Add --no-verify for that.