search

python-trio / flake8-async

Highly opinionated linter for Trio code
https://flake8-async.readthedocs.io
MIT License
17 stars 2 forks source link

Updated CONTRIBUTING.md to suggest pre-commit instead of outdated tox -e check #115

Closed jakkdl closed 1 year ago

jakkdl commented 1 year ago

fixes #114

jakkdl commented 1 year ago

I wasn't fully sure what tox line to suggest for running tests, tox -e py311 works plenty fine but can be confusing since that works despite not specifying -flake8_6 and triggering tox to install flake8, because setup.py requires flake8. But tox -e py311-flake8_6 felt overly verbose if you're not gonna be running stuff with aliases or stuff. Ended up settling on tox -e testenv which will just run the default env against current python.

@kianmeng feel free to have opinions since this maybe confused you

jakkdl commented 1 year ago

With a :+1: react from kianmeng and approval from zac I'll merge this one.

Zac-HD commented 1 year ago

I was just about to hit merge after approving, but... in-flight wifi :sweat_smile: