python-trio / flake8-async

Highly opinionated linter for Trio code
https://flake8-async.readthedocs.io
MIT License
17 stars 2 forks source link

TRIO112 false alarm on strict_exception_groups #138

Closed jakkdl closed 1 year ago

jakkdl commented 1 year ago
  • TRIO112: nursery body with only a call to nursery.start[_soon] and not passing itself as a parameter can be replaced with a regular function call.

Ah, but not if the nursery is passed strict_exception_groups=, because that would change exception types.

breaking out from #124 - in case the linter should also ignore those cases.

Zac-HD commented 1 year ago

Hmm, I think it's OK to raise a lint error (which can be noqa'd) since this is kinda weird, I just wouldn't want to automatically change the code when we could instead avoid breaking changes 😅