search

python-trio / flake8-async

Highly opinionated linter for Trio code
https://flake8-async.readthedocs.io
MIT License
17 stars 2 forks source link

Add flake8-pyi to pre-commit #150

Closed jakkdl closed 1 year ago

jakkdl commented 1 year ago

So this doesn't currently complain about anything in the .pyi files - I don't remember whether that is because I addressed all of that in a previous commit (git blame typings/flake8/options/manager.pyi shows that file has been modified three times (none of the other has)) or when generating the files, or if this never complained about anything with the generated files.

But regardless I don't think the plugin does much, if anything, for us, we only use stubs against flake8 (which is partly on it's way out), and the stubs aren't exposed to the end user in any way. But since I accidentally pushed it in #148 I thought I might as well bring it up here

jakkdl commented 1 year ago

Wait no, there's some issue where flake8-pyi isn't run in pre-commit for some reason. Running it standalone gives a bunch of errors