Closed jakkdl closed 1 year ago
I'm progressively realizing that linting the h*ck out of the eval files is actually useful - despite how irritating it can be.
Oooh, yes. One of the few things more annoying than a really strict linter is realizing that you should have started using one a while ago!
haha! so true, so true
Didn't see an option to warn on unreachable code in pyright, and I tried running Vulture for that but that started requiring me to disable 90%+ of it since it doesn't detect that visitor/leave functions are run, and a lot of other weirdness. So I settled for running .. another type checker :partying_face: But disabled a couple error codes for now. It did give some decent warnings on eval files though:
True
to...
makes it clearer that the test isn't evaluatedIt does feel silly to run double type checkers, but I'm progressively realizing that linting the h*ck out of the eval files is actually useful - despite how irritating it can be.