search

python-trio / flake8-async

Highly opinionated linter for Trio code
https://flake8-async.readthedocs.io
MIT License
17 stars 2 forks source link

test for autofix_files, fix some 91x autofixes, rejig eval_files #159

Closed jakkdl closed 1 year ago

jakkdl commented 1 year ago

branched on top of #158 F_ixes the sixth checkbox in #124 - "test that autofixed files don't generate errors", and also tests that autofixed files don't get further autofixes applied if run through the transformer again.

Finished, but somewhat messy - want to take a fresh look at visitor91x.py and the class structure there another day to see if I can make it less awful.

eval/autofix diffs are quite irritating when line numbers change, both in showing up in the diff and when developing when I manually edit the files - so it's possible I tweak something there in the future.

Feel free to review if you want, but I plan on cleaning it up and adding review comments so it should be easier after that.

jakkdl commented 1 year ago

Okay I think I'm finally happy with this, gotta resist the temptation to add more features to this already messy PR.

Zac-HD commented 1 year ago

I might let you rebase this before I try to review it 😅

jakkdl commented 1 year ago

Ah, you could just have reviewed the second commit - I can try to be more clear about that in the future. But rebased!