python-trio / flake8-async

Highly opinionated linter for Trio code
https://flake8-async.readthedocs.io
MIT License
17 stars 2 forks source link

don't autofix noqa'd errors, add --disable-noqa, add non-passing test for noqa reliability #190

Closed jakkdl closed 1 year ago

jakkdl commented 1 year ago

big refactor for noqa functionality fixing most of the remaining ones in #185, but as I added the test for all errors being properly noqa'd and was greeted with a wall of errors I realized it might be good to commit and push before tackling them. If it's a minor fix I'll just push/amend it to this PR, otherwise open a separate one.

jakkdl commented 1 year ago

turns out fixing the errors made the PR simpler, as I had mistaken assumptions about how lineno-parsing was handled in CSTTransformers.

jakkdl commented 1 year ago

uh, is it an update to trio or pyright that has it throwing new errors? It now seems to be analyzing trio properly for some reason and seeing missing objects and whether functions are coroutines.

Zac-HD commented 1 year ago

I don't know why pyright has changed, but short-term I'd just ignore tests/ and longer term #187.

jakkdl commented 1 year ago

I don't know why pyright has changed, but short-term I'd just ignore tests/ and longer term #187.

added commit which excludes tests/eval_files and tests/autofix_files

jakkdl commented 1 year ago

I don't know why pyright has changed, but short-term I'd just ignore tests/ and longer term #187.

also related to #160