use pre-commit.ci, remove workflow step running pre-commit. Add pyright to CI workflow

python-trio / flake8-async

Highly opinionated linter for Trio code

https://flake8-async.readthedocs.io

MIT License

17 stars 2 forks source link

use pre-commit.ci, remove workflow step running pre-commit. Add pyright to CI workflow #204

Closed jakkdl closed 4 months ago

jakkdl commented 4 months ago

Some minor shuffling around of things now that we have pre-commit.ci A bit ugly to duplicate the typing dependencies, but since we don't pin those it's nbd.

pyright is in pre-commit primarily because I run it locally, but the pre-commit bot will now also bump versions of it, causing it to actually run in the CI action, and everything magically works out.

todo:

edit the branch protection rules. Will do that just before merging.

jakkdl commented 4 months ago

ignoring queueing time, pyright action took 18s and pre-commit took 12.1s. Solid improvement over the old check step that took 1m24s as it didn't have access to caching for pre-commit hooks

jakkdl commented 4 months ago

I do :grin:

jakkdl commented 4 months ago

Removed check requirement, added 3.12, pyright, and pre-commit.