basic Asyncio support - Githubissues

python-trio / flake8-async

Highly opinionated linter for Trio code

https://flake8-async.readthedocs.io

MIT License

17 stars 2 forks source link

basic Asyncio support #210

Closed jakkdl closed 4 months ago

jakkdl commented 4 months ago

first steps on #208 106, 200, 21x and 9xx are supported, though no autofix.

This is rebased on top of #209, so if reviewing you should only look at the latest commit(s).

todo:

[x] update readme.md
[x] update changelog
[x] do a second pass through the diff, quite tired atm so suspect there may be silly stuff somewhere.
[ ] rewrite descriptions of --anyio / --asyncio to not be dumb. And/or have a --library flag instead.

Zac-HD commented 4 months ago

Looks good so far! Will re-review when you think it's done 👍

jakkdl commented 4 months ago

Uh, I ended up doing A Lot:tm:. But the diff didn't actually end up being all that big. The rebase might break viewing only new changes though, so you might want to review commit-by-commit.

Only ones listed in #208 not supported now is:

22X/23X/24X not having tailored error messages (and therefore being untested)
not detecting asyncio-shielded-timeouts

So I'm now comfortable saying this has decent asyncio support and we could push a release.

TODO: Oh I did rename the repository, so should update links.

jakkdl commented 4 months ago

ah oops, I realized I forgot to ask your opinion on use [trio|anyio].lowlevel.checkpoint() vs use [trio/anyio].lowlevel.checkpoint() (or something else). Both are used in different places in documentation/comments/error messages

Zac-HD commented 4 months ago

I'd probably go with the slash, but don't really care so long as we're consistent.