Closed jakkdl closed 4 months ago
Don't think this needs a version/changelog bump, but it would probably be good to have some check for if the changelog is updated in a pull request as that's been missed in the past.
I think the coverage failure on py39 is a bug in pytest-cov or coverage (??). I can reproduce it locally when running through tox. It's triggering here on line 130: https://github.com/python-trio/flake8-async/blob/f383fe696129526ff339060460535c826c51d7fd/flake8_async/visitors/visitors.py#L129-L130
continue
has the result printed, and the continue statement (now on L131) is now coveredpass
statement on L130, I get cov fail on L131 (where the continue now is). pass
might be special-cased though idk.
"hello"
, or assert True
on L130--cov-branch
made no differencecoverage run -m pytest ...
made no difference[...]
Various small fixes I noticed while going through code/doc/issues.
startable-in-context-manager
open_nursery
as a cancel scope.nursery.cancelscope.shield = True
, only fornursery.shield = True
, which is not possible)open_nursery
is itself an async function so you can't safely open a nursery anyway.